[Spring] Set basePath on Spring Api Interface @RequestMapping#7014
Open
patst wants to merge 5 commits intoOpenAPITools:masterfrom
Open
[Spring] Set basePath on Spring Api Interface @RequestMapping#7014patst wants to merge 5 commits intoOpenAPITools:masterfrom
patst wants to merge 5 commits intoOpenAPITools:masterfrom
Conversation
Zomzog
suggested changes
Oct 25, 2020
Comment on lines
+70
to
+72
| {{#-}} | ||
| {{>requestMapping}} | ||
| {{/-}} |
Contributor
There was a problem hiding this comment.
The requestMapping is never generated on the API level with this condition.
I'm not sure to understand why using {{#-}} condition to generate it.
| @@ -0,0 +1,3 @@ | |||
| {{=<% %>=}} | |||
Contributor
There was a problem hiding this comment.
It's the same one for spring-boot and spring-mvc, maybe it can be the default value of the spring generator and override only for spring-cloud?
|
plzzz merge this PR |
|
Is there anything preventing this from being merged in? There's a few tests failing, can these be solved? I'm currently stumbling over this issue. |
|
I'm also experiencing this issue right now. Please resolve the open topics and merge this request. Would be awesome to see this in the next release! Thanks! 😊 |
|
Seems to be obsolete since #10573. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1928
The
base-pathshould be set on the Api interface. This way it is working withinterfaceOnly.I removed it from the
apiController.mustachefile and added it to theapi.mustachefile.Tested locally with an example project.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @bkabrda (2020/01)