Skip to content

Typescript-angular: Mark deprecated operations with deprecated JSdoc tag#6973

Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom
daiscog:feature/document-deprecated-operations-in-angular-client
Jul 20, 2020
Merged

Typescript-angular: Mark deprecated operations with deprecated JSdoc tag#6973
macjohnny merged 2 commits intoOpenAPITools:masterfrom
daiscog:feature/document-deprecated-operations-in-angular-client

Conversation

@daiscog
Copy link
Copy Markdown
Contributor

@daiscog daiscog commented Jul 17, 2020

…ated JSDoc tag

Fixes #6972

PR checklist

  • [/] Read the contribution guidelines.
  • [/] If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • [/] Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • [/] File the PR against the correct branch: master
  • [/] Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny
Copy link
Copy Markdown
Member

@daiscog please merge the latest master into your branch

@daiscog
Copy link
Copy Markdown
Contributor Author

daiscog commented Jul 20, 2020

@macjohnny Done; all checks are now passing.

@macjohnny macjohnny added this to the 5.0.0 milestone Jul 20, 2020
@macjohnny macjohnny changed the title Typescript-angular generator: Mark deprecated operations with @deprec… Typescript-angular: Mark deprecated operations with deprecated JSdoc tag Jul 20, 2020
@macjohnny macjohnny merged commit 95bd845 into OpenAPITools:master Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[typescript-angular] Mark deprecated operations with the @deprecated JSDoc tag in typescript-angular

2 participants