Skip to content

[go-experimental] Fix generating array aliases as models#6939

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
bkabrda:go-experimental-array-models
Jul 22, 2020
Merged

[go-experimental] Fix generating array aliases as models#6939
wing328 merged 2 commits intoOpenAPITools:masterfrom
bkabrda:go-experimental-array-models

Conversation

@bkabrda
Copy link
Copy Markdown
Contributor

@bkabrda bkabrda commented Jul 14, 2020

This fixes generation of array aliases for go-experimental.

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)

@bkabrda
Copy link
Copy Markdown
Contributor Author

bkabrda commented Jul 15, 2020

FWIW, CircleCI run failed on [ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.5.0:exec (sbt-test) on project scalaz-petstore-client: Command execution failed. Process exited with an error: 1 (Exit value: 1) -> [Help 1], which I think is a flake unrelated to this PR.

@kemokemo
Copy link
Copy Markdown
Contributor

Hi @bkabrda .
I have checked the code generation with a simple example. It looks good. 😺

@wing328 wing328 added this to the 5.0.0 milestone Jul 22, 2020
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 22, 2020

Pull the latest master into this branch to resolve the CircleCI failure. Let's see how that goes.

@wing328 wing328 merged commit 763b8fb into OpenAPITools:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants