Make accept header consistent with sync version#6922
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jul 17, 2020
Merged
Make accept header consistent with sync version#6922wing328 merged 2 commits intoOpenAPITools:masterfrom
wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
Member
mh03r932
force-pushed
the
mh03r932-patch-1
branch
from
ecb76e6 to
98527c5
Compare
* make sync and async version use same logic * generate samples for csharp-netcore using generate-samples.sh
mh03r932
force-pushed
the
mh03r932-patch-1
branch
from
98527c5 to
9fe8bc5
Compare
Contributor
Author
|
Done. FYI I forced pushed that because I made a C&P error and wanted to keep this PR to a single commit. |
shibayan
suggested changes
Jul 14, 2020
| if (localVarContentType != null) localVarRequestOptions.HeaderParameters.Add("Content-Type", localVarContentType); | ||
|
|
||
| var localVarAccept = {{packageName}}.Client.ClientUtils.SelectHeaderAccept(_accepts); | ||
| if (localVarAccept != null) localVarRequestOptions.HeaderParameters.Add("Accept", localVarAccept); |
Contributor
There was a problem hiding this comment.
Modify from tabs to spaces to match the indentation of the existing code.
mh03r932
commented
Jul 14, 2020
Contributor
Author
mh03r932
left a comment
mh03r932
left a comment
There was a problem hiding this comment.
That makes sense
mh03r932
commented
Jul 14, 2020
* change tabs to spaces to match existing code
mh03r932
force-pushed
the
mh03r932-patch-1
branch
from
ad0006a to
15b28cf
Compare
shibayan
approved these changes
Jul 15, 2020
Member
|
CircleCI failure already fixed in the master. |
wing328
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the accept and content-type header consistent with the sync version
This should fix issue #6821
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master