[Java][RestTemplate] Use abstraction for files#6912
Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom Jul 20, 2020
Merged
[Java][RestTemplate] Use abstraction for files#6912wing328 merged 8 commits intoOpenAPITools:masterfrom
wing328 merged 8 commits intoOpenAPITools:masterfrom
Conversation
Sync with master
…llow flexible options in generated client when a file is needed (OpenAPITools#6715)
…llow flexible options in generated client when a file is needed (OpenAPITools#6715)
…llow flexible options in generated client when a file is needed (OpenAPITools#6715)
5 tasks
Contributor
Author
|
Adding the Java technical committee as requested - @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda. Please review. |
Contributor
Author
|
A kind reminder. Would appreciate a review @wing328 @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @bkabrda. Thanks. |
Sync with master
…straction_for_files
…va/RestTemplate to allow flexible options in generated client when a file is needed.
Member
|
CircleCI failure not related to this change. |
wing328
approved these changes
Jul 20, 2020
Member
wing328
left a comment
There was a problem hiding this comment.
Tested locally and the result is good.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new "useAbstractionForFiles" config option that uses abstract objects instead of files where files are needed. With this option, the user will be able to use byte array or input stream instead of java.io.File. The new config option is currently supported only by the resttemplate library.
Fix the dir path mentioned in the pull request template.
To close #6715
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master