[Java][Native] added WithHttpInfo method for async-native#6903
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Jul 17, 2020
Merged
Conversation
| * {{notes}} | ||
| * @param {{operationId}}Request {@link API{{operationId}}Request} | ||
| * @return ApiResponse<{{#returnType}}{{returnType}}{{/returnType}}{{^returnType}}Void{{/returnType}}> | ||
| * @return {{#asyncNative}}CompletableFuture<{{/asyncNative}}ApiResponse<{{#returnType}}{{returnType}}{{/returnType}}{{^returnType}}Void{{/returnType}}>{{#asyncNative}}>{{/asyncNative}} |
Contributor
There was a problem hiding this comment.
I see in the changes below that < is used directly, can't we do the same here?
Contributor
Author
There was a problem hiding this comment.
It is a part of java doc, can't use < directly.
| HttpRequest.Builder localVarRequestBuilder = {{operationId}}RequestBuilder({{#allParams}}{{paramName}}{{#hasMore}}, {{/hasMore}}{{/allParams}}); | ||
| return memberVarHttpClient.sendAsync( | ||
| localVarRequestBuilder.build(), | ||
| HttpResponse.BodyHandlers.ofString()).thenComposeAsync(localVarResponse -> { |
Contributor
There was a problem hiding this comment.
instead of copy/pasting from above, can we extract this into a separate method?
Contributor
Author
There was a problem hiding this comment.
The functions using to compute another CompletionStage are similar, but return types different. Create a seperate method getApiExection(...) to handle operation error.
wing328
approved these changes
Jul 17, 2020
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
LGTM but I didn't test it locally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the PR
This PR added WithHttpInfo method for asyncNative, it includes the changes below:
@wing328 @cbornet @jeff9finger @bbdouglas @sreeshas @jfiala @lukoyanov @karismann @Zomzog @lwlee2608 @bkabrda @jfeltesse-mdsol @jcarres-mdsol
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master