Skip to content

Conversation

@houqp
Copy link
Contributor

@houqp houqp commented Jun 27, 2020

Based on https://tools.ietf.org/html/draft-ietf-appsawg-http-problem-00, the content-type would be application/problem+json

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@houqp
Copy link
Contributor Author

houqp commented Jun 27, 2020

@antihax @bvwells @grokify @kemokemo @bkabrda, could you help review this PR?

@kemokemo
Copy link
Contributor

@houqp Thank you so much for your PR! 😄 LGTM!

@houqp
Copy link
Contributor Author

houqp commented Jul 26, 2020

@wing328 could you help take a look at this PR?

@wing328 wing328 merged commit dba14f5 into OpenAPITools:master Jul 26, 2020
@wing328
Copy link
Member

wing328 commented Jul 26, 2020

@houqp just merged. Sorry for the delay. Thanks for the contribution.

@wing328 wing328 added this to the 5.0.0 milestone Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants