[Elixir] Adds workaround for httpc for post/put/patch requests#5682
Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom Jan 26, 2021
Merged
[Elixir] Adds workaround for httpc for post/put/patch requests#5682wing328 merged 3 commits intoOpenAPITools:masterfrom
wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
mrmstn
changed the title
Contributor
Author
|
Thins I need to check before merging:
|
richardwhiuk
changed the title
mrmstn
force-pushed
the
5403-HTTPC-POST-BODY-FIX
branch
from
9056dec to
a251e81
Compare
mrmstn
changed the title
Contributor
Author
|
I've changed the way to handle this.. now, the generator looks for a required body params (forms included). If one is found, the patch doesn't need to take place. The patch itself will simply look if a body param was set by one of the optional body params. If the body is still not present or nil, it it will be replaces by an empty string. @wing328 Could you do me the honor and give me a short review on this PR? :) |
wing328
approved these changes
Jan 26, 2021
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
LGTM. Local tests passed as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will fix #5403 by adding an empty string if no body was defined for requests with a method of
POST,PATCHorPUT.PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc: @wing328