typescript-angular: support angular 9#5370
Merged
macjohnny merged 6 commits intoOpenAPITools:masterfrom Feb 20, 2020
topce:v9-module-with-providers
Merged
typescript-angular: support angular 9#5370macjohnny merged 6 commits intoOpenAPITools:masterfrom topce:v9-module-with-providers
macjohnny merged 6 commits intoOpenAPITools:masterfrom
topce:v9-module-with-providers
Conversation
also render in tempate module with providers
and commit result
macjohnny
approved these changes
Feb 19, 2020
Member
macjohnny
left a comment
macjohnny
left a comment
There was a problem hiding this comment.
LGTM
Thanks a lot!
However, the samples need to be re-generated with the current version
macjohnny
changed the title
amakhrov
reviewed
Feb 19, 2020
Contributor
Author
|
Wow one day after PR and already reviewed |
Contributor
|
There's a typo in TypeScriptAngularClientCodegen.java#L335 which says |
Member
|
@Veluria do you filing a PR with the fix when you've time? |
Contributor
|
I can send a PR later. |
Member
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* fix code to support ng9 also render in tempate module with providers * execute script .\bin\windows\typescript-angular-petstore-all.bat and commit result * re-generate samples * remove whitespace, re-generate samples * re-generate samples * code cleanup Co-authored-by: Esteban Gehring <[email protected]>
Member
|
@topce thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for angular 9
fix api.module.ts to generate
instead of
ModuleWithProvidersfor more info check
migration-module-with-providers
fixes #5246
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)