[C#] add support for client certificates#5328
Merged
wing328 merged 5 commits intoOpenAPITools:masterfrom Feb 20, 2020
jornhd:issue_5306__support_for_client_certificates
Merged
[C#] add support for client certificates#5328wing328 merged 5 commits intoOpenAPITools:masterfrom jornhd:issue_5306__support_for_client_certificates
wing328 merged 5 commits intoOpenAPITools:masterfrom
jornhd:issue_5306__support_for_client_certificates
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Contributor
Author
|
Thanks. I think I've fixed it now. I noticed that that the CircleCI tests
failed. Something about uncommitted changes. Do you know how to fix this?
mvh. Jørn H. Dalvik
lør. 15. feb. 2020 kl. 17:08 skrev William Cheng <[email protected]>:
… Thanks for the PR but your commit (as shown in the Commits tab) is not
linked to your Github account, which means this PR won't count as your
contribution in
https://github.com/OpenAPITools/openapi-generator/graphs/contributors.
Let me know if you need help fixing it.
Ref:
https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#5328?email_source=notifications&email_token=ALXDVZU3W4DUUEDFIQWZIRLRDAHQ3A5CNFSM4KVXPMW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEL3QJRY#issuecomment-586613959>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALXDVZVDEC3XLXH76F3FIULRDAHQ3ANCNFSM4KVXPMWQ>
.
|
Member
wing328
changed the title
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* Issue OpenAPITools#5306: Added support for client certificates for csharp-netcore * Added missing windows petstore scripts * Updated sample client * Added missing openapi3 samples * Added missing images causing openapi3 test projects to fail
Member
|
@jornhd thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@shibayan Here is template changes for solving the issue #5306 . New samples has been generated, along with missing openapi3 samples and batch files.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.