typescript-fetch: Base Path can't be set to empty string#5305
Merged
macjohnny merged 2 commits intoOpenAPITools:masterfrom Feb 13, 2020
Merged
typescript-fetch: Base Path can't be set to empty string#5305macjohnny merged 2 commits intoOpenAPITools:masterfrom
macjohnny merged 2 commits intoOpenAPITools:masterfrom
Conversation
macjohnny
changed the title
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
…enAPITools#5305) Co-authored-by: Esteban Gehring <[email protected]>
Member
|
@duxiaofeng-github thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5282, allows developer to set base_path to an empty string.
The code check the
this.configuration.basePath, if it's NOT A NULL OR UNDEFINED, then usethis.configuration.basePath, otherwise use theBASE_PATHPR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.