[typescript] Don't hardcode the date type if user has mapped it#5266
Merged
macjohnny merged 6 commits intoOpenAPITools:masterfrom Feb 12, 2020
Merged
Conversation
If the user has set --type-mappings Date=foo, respect this setting instead of hardcoding the date type.
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Contributor
Author
macjohnny
approved these changes
Feb 10, 2020
amakhrov
reviewed
Feb 10, 2020
amakhrov
reviewed
Feb 10, 2020
macjohnny
reviewed
Feb 11, 2020
macjohnny
approved these changes
Feb 11, 2020
Member
|
@asmundg can you please re-generate all typescript samples? |
4 tasks
wing328
pushed a commit
that referenced
this pull request
Mar 3, 2020
* Add failing tests for typescript type declaration * Refactor array and map child type string fallback * Add unaliasSchema to typescript getTypeDeclaration * TypeScriptRxjs: Use Blob as file type declaration This was inadvertantly changed in #5266
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
…APITools#5266) * [typescript] Don't hardcode the date type if user has mapped it If the user has set --type-mappings Date=foo, respect this setting instead of hardcoding the date type. * Use default type mappings for date/date-time * Use typeMapping mechanism correctly * Add default mapping for angular and node to preserve behavior * One more change to keep current behavior * Add default type mappings to the other TS generators
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
* Add failing tests for typescript type declaration * Refactor array and map child type string fallback * Add unaliasSchema to typescript getTypeDeclaration * TypeScriptRxjs: Use Blob as file type declaration This was inadvertantly changed in OpenAPITools#5266
Member
|
@asmundg thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
If the user has set --type-mappings Date=foo, respect this setting
instead of hardcoding the date type.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.