[kotlin][client] respect sortModelPropertiesByRequiredFlag#5211
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Feb 13, 2020
Merged
Conversation
wing328
approved these changes
Feb 13, 2020
Member
wing328
left a comment
wing328
left a comment
There was a problem hiding this comment.
The fix looks reasonable to me
Contributor
|
@4brunu @wing328 , this change has effectively removed all inherited properties from child classes. In the template, Maybe instead it should be |
Contributor
Author
|
Maybe we can change |
5 tasks
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#4707 introduced a flag
sortModelPropertiesByRequiredFlagto control how the model orders the properties to fix #4705.By default the model properties already are sorted by the required here
openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java
Line 76 in 4fa096f
And the user can choose if he wants to sort the model properties already by the required or not here
openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractKotlinCodegen.java
Line 200 in 4fa096f
With #4453 this become non functional.
This PR restores this functionality.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11)