[dart] fix toJson does not handle complex type#5189
Closed
arndt-s wants to merge 1 commit intoOpenAPITools:masterfrom
arndt-s:fix/4562-dart-toJson-does-not-handle-object
Closed
[dart] fix toJson does not handle complex type#5189arndt-s wants to merge 1 commit intoOpenAPITools:masterfrom arndt-s:fix/4562-dart-toJson-does-not-handle-object
arndt-s wants to merge 1 commit intoOpenAPITools:masterfrom
arndt-s:fix/4562-dart-toJson-does-not-handle-object
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
Can you please merge the latest master of the official repo into your branch and regenerate the Dart petstore samples? That should fix the CircleCI failure. |
5 tasks
Contributor
Author
|
fixed in #6730 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4562
Tests have been done by checking if models still compile. Did not figure out how to write testfiles for methods in generated sources.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.@ircecho (2017/07) @swipesight (2018/09) @jaumard (2018/09) @nickmeinhold (2019/09) @athornz (2019/12) @amondnet (2019/12)