[BUG][R] use loadNamespace instead of package:pkgName string#4614
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Nov 29, 2019
LiNk-NY:master
Merged
[BUG][R] use loadNamespace instead of package:pkgName string#4614wing328 merged 2 commits intoOpenAPITools:masterfrom LiNk-NY:master
wing328 merged 2 commits intoOpenAPITools:masterfrom
LiNk-NY:master
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
Looks good to me. If no one has further feedback, I'll merge it on the coming Friday. |
saigiridhar21
approved these changes
Nov 27, 2019
Member
|
@LiNk-NY thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi William, @wing328
This change makes use of
loadNamespaceinstead ofpackage:{{packageName}}.The latter requires that the package be attached to the search path when using
as.environment(this can cause issues when it is not). The current change loadsthe namespace before its use.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc: @Ramanth @saigiridhar21