Skip to content

Maintains state of hasMore when security is filtered#4585

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
jasonculverhouse:jason/issue4584
Nov 25, 2019
Merged

Maintains state of hasMore when security is filtered#4585
wing328 merged 1 commit intoOpenAPITools:masterfrom
jasonculverhouse:jason/issue4584

Conversation

@jasonculverhouse
Copy link
Copy Markdown
Contributor

@jasonculverhouse jasonculverhouse commented Nov 22, 2019 •
edited
Loading

See
#4584

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
[INFO] 
[INFO] openapi-generator-project .......................... SUCCESS [  1.792 s]
[INFO] openapi-generator-core ............................. SUCCESS [  6.641 s]
[INFO] openapi-generator (core library) ................... SUCCESS [ 52.734 s]
[INFO] openapi-generator (executable) ..................... SUCCESS [ 19.343 s]
[INFO] openapi-generator (maven-plugin) ................... SUCCESS [  6.183 s]
[INFO] openapi-generator-gradle-plugin (maven wrapper) .... SUCCESS [ 19.095 s]
[INFO] openapi-generator-online ........................... SUCCESS [  5.514 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:51 min
[INFO] Finished at: 2019-11-22T18:18:20Z

wing328
wing328 approved these changes Nov 25, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CI failure already addressed in the master.

@wing328 wing328 added this to the 4.2.2 milestone Nov 25, 2019
@wing328 wing328 merged commit d0e838e into OpenAPITools:master Nov 25, 2019
@wing328
Copy link
Copy Markdown
Member

wing328 commented Dec 2, 2019

@jasonculverhouse thanks for the PR, which has been included in the v4.2.2 release: https://twitter.com/oas_generator/status/1201432648544972800

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328 wing328 wing328 approved these changes

Assignees

No one assigned

Labels

Feature: Generator Issue: Bug

Projects

None yet

Milestone

4.2.2

Development

Successfully merging this pull request may close these issues.

2 participants

@jasonculverhouse @wing328