[BUG][R] Fix documentation in R package#4580
Merged
wing328 merged 9 commits intoOpenAPITools:masterfrom Nov 26, 2019
LiNk-NY:master
Merged
[BUG][R] Fix documentation in R package#4580wing328 merged 9 commits intoOpenAPITools:masterfrom LiNk-NY:master
wing328 merged 9 commits intoOpenAPITools:masterfrom
LiNk-NY:master
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Member
|
Thanks for the PR. Please run |
Contributor
Author
|
Thanks William @wing328 for all your help here and via email. [Update]: It looks like the CI is having issues with setup Best, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It updates the mustache template and simplifies the linking in the documentation so that it works for "non-primitive" types. R is good at looking for the name of the page and by topic with the provided name so that the correct documentation page is displayed.
There are still some unresolved issues concerning some "list" types that show up as
array[class]but I didn't touch the code for these primitive types. I've run it for ther-petstore.shand another API. The results are pretty satisfactory.Reference issue: See #4428
I must say that there was some resistance from @Ramanth which was quite unhelpful because he did not provide concrete evidence to his claim. See: #4428 (comment)
I have tested the generation with the Jar file since and it is working.
Thanks.
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.cc: @Ramanth @saigiridhar21