[PHP] Remove model prefix/suffix from inline enum var names#4489
Merged
ackintosh merged 2 commits intoOpenAPITools:masterfrom Feb 21, 2020
Merged
[PHP] Remove model prefix/suffix from inline enum var names#4489ackintosh merged 2 commits intoOpenAPITools:masterfrom
ackintosh merged 2 commits intoOpenAPITools:masterfrom
Conversation
This resolves issue OpenAPITools#4403. On a model `Foo` with an inline enum `Bar` which has a possible string value `baz`. we should generate a `FooDTO::BAR_BAZ` constant, not `FooDTO::BAR_DTO_BAZ`.
Contributor
Author
ackintosh
approved these changes
Feb 19, 2020
Contributor
ackintosh
left a comment
ackintosh
left a comment
There was a problem hiding this comment.
Thanks for the PR! LGTM. 😃
MikailBag
pushed a commit
to MikailBag/openapi-generator
that referenced
this pull request
Mar 23, 2020
…ools#4489) * [PHP] Remove model prefix/suffix from inline enum var names This resolves issue OpenAPITools#4403. On a model `Foo` with an inline enum `Bar` which has a possible string value `baz`. we should generate a `FooDTO::BAR_BAZ` constant, not `FooDTO::BAR_DTO_BAZ`. * Empty commit for another CI run
Member
|
@hinrik thanks for the PR, which has been included in the 4.3.0 release: https://twitter.com/oas_generator/status/1243455743937789952 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issue #4403.
On a model
Foowith an inline enumBarwhich has a possible stringvalue
baz. we should generate aFooDTO::BAR_BAZconstant, notFooDTO::BAR_DTO_BAZ.