Skip to content

[go-experimental] Remove duplicated line#4410

Merged
jimschubert merged 4 commits intoOpenAPITools:masterfrom
zippolyte:hippo/rm_dup
Dec 17, 2019
Merged

[go-experimental] Remove duplicated line#4410
jimschubert merged 4 commits intoOpenAPITools:masterfrom
zippolyte:hippo/rm_dup

Conversation

@zippolyte
Copy link
Copy Markdown
Contributor

@zippolyte zippolyte commented Nov 7, 2019

#3322 Introduces a duplication of the return statement in https://github.com/OpenAPITools/openapi-generator/pull/3322/files#diff-5c6a68868625dbd29066148ecab2c4b8R334
This PR removes that duplication

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @bkabrda

@zippolyte zippolyte changed the title Remove duplicated line [go-experimental] Remove duplicated line Nov 7, 2019
@zippolyte
Copy link
Copy Markdown
Contributor Author

zippolyte commented Nov 7, 2019 •
edited
Loading

Looks like #3989 also included some changes that could generate duplicated imports.
https://github.com/OpenAPITools/openapi-generator/pull/3989/files#diff-e1c002d29e771fb5b795a039f401a360R6-R8
Fixed, my mistake

bkabrda
bkabrda suggested changes Nov 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please try to make sure that you're running this with the latest checkout of openapi-generator and that you're using the jar built from this latest checkout. I think you might be using an older version locally which causes the double-import issue.

Comment thread samples/client/petstore/go-experimental/go-petstore/.openapi-generator/VERSION Outdated
Copy link
Copy Markdown
Contributor

@bkabrda bkabrda Nov 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change doesn't look right. Did you properly rebase your local copy to latest master?

bkabrda
bkabrda approved these changes Nov 8, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@bkabrda bkabrda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@zippolyte
Copy link
Copy Markdown
Contributor Author

zippolyte commented Dec 5, 2019

Hey @wing328, I would love to get this merged in. Could you take a look ?
Thanks !

jirikuncar
jirikuncar approved these changes Dec 10, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@jirikuncar jirikuncar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zippolyte!

jimschubert
jimschubert approved these changes Dec 17, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@jimschubert jimschubert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jimschubert jimschubert merged commit 83cb420 into OpenAPITools:master Dec 17, 2019
@zippolyte zippolyte deleted the hippo/rm_dup branch December 17, 2019 12:38
@wing328 wing328 added this to the 4.2.3 milestone Dec 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jimschubert jimschubert jimschubert approved these changes

+2 more reviewers

@jirikuncar jirikuncar jirikuncar approved these changes

@bkabrda bkabrda bkabrda approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client: Go Issue: Bug

Projects

None yet

Milestone

4.2.3

Development

Successfully merging this pull request may close these issues.

5 participants

@zippolyte @jimschubert @jirikuncar @bkabrda @wing328