Skip to content

Add test case for produces#420

Merged
jmini merged 1 commit intoOpenAPITools:masterfrom
jmini:produces_test_cases
Jun 30, 2018
Merged

Add test case for produces#420
jmini merged 1 commit intoOpenAPITools:masterfrom
jmini:produces_test_cases

Conversation

@jmini
Copy link
Copy Markdown
Member

@jmini jmini commented Jun 30, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.1.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @OpenAPITools/generator-core-team

Description of the PR

Ensure that addProducesInfo(OpenAPI openAPI, ApiResponse inputResponse, CodegenOperation codegenOperation) works for the 2 cases discussed in #361.

This PR is just about adding unit-test, no changes to the existing implementation.

@jmini
Copy link
Copy Markdown
Member Author

jmini commented Jun 30, 2018

Self approving since unit tests only (no change to the existing implementation) and all CI jobs green.

@jmini jmini added this to the 3.1.0 milestone Jun 30, 2018
@jmini jmini merged commit 2604c93 into OpenAPITools:master Jun 30, 2018
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant