[typescript-fetch] prefix request interface#3740
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Aug 23, 2019
Merged
[typescript-fetch] prefix request interface#3740macjohnny merged 1 commit intoOpenAPITools:masterfrom
macjohnny merged 1 commit intoOpenAPITools:masterfrom
Conversation
Prefix generated request interface names with API classname rather than using namespaces, because namespaces are not well-supported by some tooling (in particular, Babel).
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Contributor
Author
|
@macjohnny updated approach to request name collision problem. cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09) @topce (2018/10) @akehir (2019/07) |
Contributor
Author
|
Build breakage looks unrelated. |
jimschubert
added a commit
that referenced
this pull request
Aug 25, 2019
* master: (45 commits) update python samples Two tiny fixes for Java Vertx client (#3683) Exclude "test" from packages so that it is not installed as top-level package when "pip installing" the generated sdk (#3731) [java-client] add unit test for JDK 11 HttpClient (#3735) [R] feat(r): handling error response for 3xx cases (#3571) [Dart] Avoid redundant null checking in fromJson (#3632) [core] Set isMultipart=true for multipart operations, fix possible NPE (#3750) reenable kotlin client tests in shippable ci (#3751) Fix null assignation to header/query param map (#3749) Mockito 3.0.0 (#3732) Update to swagger-parser to 2.0.14-OpenAPITools.org-1 (#3737) Add a link to a Qiita blog post (#3747) update csharp samples Simple spelling error in dotnet core comments (#3746) better support for multipart (#3736) [typescript-fetch] fix #1998: prefix req ifaces. (#3740) cpp-qt5-client: add valgrind memory test (#3663) [typescript-angular] Encode objects for multipart/form-data with json - fixes #2733 (#3738) [BUG] Https protocol schema is not handled correctly in java 11 native code #3729 (#3730) comment out kotlin client tests ...
wing328
changed the title
wing328
changed the title
wing328
changed the title
Member
|
@jgiles thanks for the PR, which has been included in the v4.1.1 release: https://twitter.com/oas_generator/status/1165944867391860737 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prefix generated request interface names with API classname rather than
using namespaces, because namespaces are not well-supported by some
tooling (in particular, Babel).
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
Change the approach for #1998 to prefixing all request interface types to avoid problems with Babel.
fixes #1998