Conversation
Member
Author
|
@dkliban please have a look when you've time. |
Member
Author
|
Local tests (Ruby Faraday) look good: |
dkliban
reviewed
Aug 2, 2019
| @ssl_client_key = nil | ||
| {{/isFaraday}} | ||
| {{^isFaraday}} | ||
| @verify_ssl = true |
Contributor
There was a problem hiding this comment.
You should only include the TLS settings for Typhoeus when not isFaraday.
dkliban
approved these changes
Aug 2, 2019
Contributor
dkliban
left a comment
dkliban
left a comment
There was a problem hiding this comment.
I generated a client based on Faraday library and tested that it works correctly. I also read through the client code and it looked as expected.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.Description of the PR
cc @cliffano (2017/07) @zlx (2017/09) @autopp (2019/02)