Better Rust client imports#3332
Merged
bjgill merged 2 commits intoOpenAPITools:masterfrom Jul 18, 2019
Merged
Conversation
* No more "unused_imports" in models for serde_json::Value. * No more compilation problem for apis requiring serde_json::Value. * "crate::" prefix for models and apis imports, for compatibility with Rust 2018 edition.
bjgill
approved these changes
Jul 15, 2019
Contributor
bjgill
left a comment
bjgill
left a comment
There was a problem hiding this comment.
Looks good, thanks!
I guess we'll eventually want to drop support for Rust 2015, but that doesn't feel particularly important/urgent yet.
Contributor
|
I'll give this until Thursday morning, and then merge. |
Contributor
|
And merged. This should be released in 4.1.0 (due at the end of July) |
Member
|
@bcourtine thanks for the PR, which has been included in the 4.1.0 release: https://twitter.com/oas_generator/status/1160000504455319553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first.master,4.1.x,5.0.x. Default:master.cc @frol @farcaller @bjgill @wing328
Description of the PR
Better imports:
serde_json::Valueunused import in models.Theses changes are backward compatible.