Do not check status code for default response #3322
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -595,6 +595,25 @@ public void testLeadingSlashIsAddedIfMissing() { | |
| Assert.assertEquals(co2.path, "/some/path"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testDefaultResponseShouldBeLast() { | ||
| OpenAPI openAPI = TestUtils.createOpenAPI(); | ||
| Operation myOperation = new Operation().operationId("myOperation").responses( | ||
| new ApiResponses() | ||
| .addApiResponse( | ||
| "default", new ApiResponse().description("Default")) | ||
| .addApiResponse( | ||
| "422", new ApiResponse().description("Error")) | ||
|
Member
There was a problem hiding this comment. @thiagoarrais I notice that you've updated the test to replace 2xx with 4xx status code. Does it mean the original "201" status code test fail?
Contributor
Author
There was a problem hiding this comment. No. 422 just seemed more realistic. 201 is a success and more likely to be equated to the default case. |
||
| ); | ||
| openAPI.path("/here", new PathItem().get(myOperation)); | ||
| final DefaultCodegen codegen = new DefaultCodegen(); | ||
| codegen.setOpenAPI(openAPI); | ||
|
|
||
| CodegenOperation co = codegen.fromOperation("/here", "get", myOperation, null); | ||
| Assert.assertEquals(co.responses.get(0).message, "Error"); | ||
| Assert.assertEquals(co.responses.get(1).message, "Default"); | ||
| } | ||
|
|
||
| @Test | ||
| public void testResponseWithNoSchemaInHeaders() { | ||
| OpenAPI openAPI = TestUtils.createOpenAPI(); | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes in DefaultCodegen
cc @OpenAPITools/generator-core-team