Option to overwrite only changed files#2451
Merged
wing328 merged 21 commits intoOpenAPITools:masterfrom Mar 20, 2019
Merged
Conversation
Bring my fork up to date with base
Catch up to mothership
…e option. Add unit test.
…illis() on Linux.
* Add blank comment lines to satisfy PR feedback * Remove tabs
# Conflicts: # modules/openapi-generator-cli/src/main/java/org/openapitools/codegen/cmd/Generate.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/AbstractGenerator.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/CodegenConfig.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/DefaultGenerator.java # modules/openapi-generator/src/main/java/org/openapitools/codegen/config/CodegenConfigurator.java # modules/openapi-generator/src/test/java/org/openapitools/codegen/DefaultGeneratorTest.java
wing328
reviewed
Mar 20, 2019
Member
|
cc @OpenAPITools/generator-core-team |
wing328
changed the title
Member
|
@wheezil thanks for the contribution. Can you please also add this option to the maven plugin and gradle plugin? |
Contributor
Author
|
W00T! My second PR :-) |
Member
|
It's not difficult. Just search for another option "generateAliasAsModel" in the plugins and you will know where to add the code for your new option. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
Add option --minimal-overwrite which will cause output files to be written to a temp file, compared to any existing file, and if different renamed. On build systems (such as MSBuild) that was weak dependency rules, this can help to prevent triggering of massive recompile on every build.
This resolves conflicts with changes from other authors in which new File() was replaced by Paths.get(), I kept the Paths.get() updates where applicable.
Related PRs: #1397, #1391