Skip to content

Comments

[csharp][generichost] Add HTTP client name to fix client duplicity#22118

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
komercka:named-http-clients-fix-dumplicit-api-names
Jan 26, 2026
Merged

[csharp][generichost] Add HTTP client name to fix client duplicity#22118
wing328 merged 2 commits intoOpenAPITools:masterfrom
komercka:named-http-clients-fix-dumplicit-api-names

Conversation

@McMlok
Copy link
Contributor

@McMlok McMlok commented Oct 13, 2025

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR solves a reported issue, reference it using GitHub's linking syntax (e.g., having "fixes #123" present in the PR description)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

I add HTTP Client name to prevent duplicit client registration if final application reference two or more generated APIs which contains API with same name. HTTP Client registration use only type name not full name including namespace. This fixes #22082

@mandrean, @shibayan, @Blackclaws, @lucamazzanti, @iBicha

@devhl-labs
Copy link
Contributor

Interesting change. I think its ok as long as the checks pass.

@McMlok
Copy link
Contributor Author

McMlok commented Oct 15, 2025

Sorry for dumb question. Is there anything I have to do? Github Action pass on last commit, first has a problem with wrong white spaces and samples. And all CircleCI runs also pass. Did I miss something?

@Mythir
Copy link
Contributor

Mythir commented Dec 17, 2025

Any progress on getting this merged? I am also running into the conflicts that this PR is supposed to fix. (Thanks for taking the initiative to fix this by the way).

@devhl-labs
Copy link
Contributor

@wing328 Can you merge?

@wing328 wing328 merged commit a4985ca into OpenAPITools:master Jan 26, 2026
61 checks passed
@wing328
Copy link
Member

wing328 commented Jan 26, 2026

Done. Sorry for the delay.

@wing328 wing328 added this to the 7.20.0 milestone Jan 26, 2026
kingofdisasterr pushed a commit to kingofdisasterr/openapi-generator that referenced this pull request Jan 27, 2026
…penAPITools#22118)

* Add HTTP client name to fix client duplicity

* Fix samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [csharp][generichost] Duplicit HTTP client registrations in factory

4 participants