[csharp][generichost] Add HTTP client name to fix client duplicity#22118
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jan 26, 2026
Merged
Conversation
Contributor
|
Interesting change. I think its ok as long as the checks pass. |
Contributor
Author
|
Sorry for dumb question. Is there anything I have to do? Github Action pass on last commit, first has a problem with wrong white spaces and samples. And all CircleCI runs also pass. Did I miss something? |
Contributor
|
Any progress on getting this merged? I am also running into the conflicts that this PR is supposed to fix. (Thanks for taking the initiative to fix this by the way). |
Contributor
|
@wing328 Can you merge? |
Member
|
Done. Sorry for the delay. |
kingofdisasterr
pushed a commit
to kingofdisasterr/openapi-generator
that referenced
this pull request
Jan 27, 2026
…penAPITools#22118) * Add HTTP client name to fix client duplicity * Fix samples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)I add HTTP Client name to prevent duplicit client registration if final application reference two or more generated APIs which contains API with same name. HTTP Client registration use only type name not full name including namespace. This fixes #22082
@mandrean, @shibayan, @Blackclaws, @lucamazzanti, @iBicha