[csharp] Ensure unique property names#21649
Conversation
|
we suggest users to use name mapping options: https://github.com/openapitools/openapi-generator/blob/master/docs/customization.md#name-mapping to handle duplicated names in the output (we tried adding a numeric suffix before and it turned out no one wants to use a model with properties id1, id2, id3, etc even though it compiles) |
|
Why not both? Get it to compile and when they don't like the suffix then use the map. I will concede that numbering could be inconsistent if the yaml or java change, but it should definitely compile one way or another. |
|
never said we shouldn't do both or not adding X different ways to handle such case just sharing what we went through and the feedback from users when trying to handle such case |
* started fixing multiple issues * weather api builds * added docstring * ensure property names are unique * force pr gates to restart * force pr gates to restart * force pr gates to restart * force pr gates to restart
Partial fix for #21585
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)