[JavaJaxrsResteasy] add @Valid to getter methods#2039
Closed
tnmtechnologies wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
Conversation
4 tasks
wing328
reviewed
Feb 15, 2019
| @ApiModelProperty({{#example}}example = "{{{example}}}", {{/example}}{{#required}}required = {{required}}, {{/required}}value = "{{{description}}}") | ||
| @JsonProperty("{{baseName}}") | ||
| {{#useBeanValidation}}{{>beanValidation}}{{/useBeanValidation}} public {{{datatypeWithEnum}}} {{getter}}() { | ||
| {{#useBeanValidation}}{{>beanValidation}}{{^isPrimitiveType}}{{^isDate}}{{^isDateTime}}{{^isString}}{{^isFile}}@Valid{{/isFile}}{{/isString}}{{/isDateTime}}{{/isDate}}{{/isPrimitiveType}}{{/useBeanValidation}} |
Member
There was a problem hiding this comment.
To avoid blank lines, please use the following instead:
{{#useBeanValidation}}
{{>beanValidation}}{{^isPrimitiveType}}{{^isDate}}{{^isDateTime}}{{^isString}}{{^isFile}}@Valid{{/isFile}}{{/isString}}{{/isDateTime}}{{/isDate}}{{/isPrimitiveType}}
{{/useBeanValidation}}
wing328
reviewed
Feb 15, 2019
| @@ -1,4 +1,6 @@ | |||
| import io.swagger.annotations.*; | |||
| {{#useBeanValidation}}import javax.validation.Valid;{{/useBeanValidation}} | |||
|
|
|||
Member
There was a problem hiding this comment.
@tnmtechnologies maybe we don't need another blank line here?
Contributor
Author
There was a problem hiding this comment.
You are right, no problem to remove the blank line.
chameleon82
reviewed
Aug 4, 2019
|
|
||
| @ApiModelProperty(value = "") | ||
| @JsonProperty("id") | ||
|
|
Contributor
There was a problem hiding this comment.
Which code style you following to put whitespace between method and annotations? Isn't redundant?
5 tasks
Contributor
|
I addressed the remaining comments in #15064. Please have a look there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,. Default:3.4.x,4.0.xmaster.Description of the PR
fix issue #1698
@wing328 @jmini