Skip to content

[typescript-fetch] [BUG] Fix duplication of ModelNamePrefix in import statements#20109

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
ASterdyniak:fix_issue19039
Dec 6, 2024
Merged

[typescript-fetch] [BUG] Fix duplication of ModelNamePrefix in import statements#20109
macjohnny merged 1 commit intoOpenAPITools:masterfrom
ASterdyniak:fix_issue19039

Conversation

@ASterdyniak
Copy link
Copy Markdown
Contributor

@ASterdyniak ASterdyniak commented Nov 15, 2024

This fixes an issue introduced in version 7.6.0. When using the ModelNamePrefix option with typescript-fetch, the given prefix is duplicated in import statements leading to compilation failure (see issue for how to reproduce).

The root case is that the method toModelFilename that is adding prefix and suffix is called twice when generating the variables used to create import statements.

Fixes #19039

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.x.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10)

@ASterdyniak
Copy link
Copy Markdown
Contributor Author

cc @En0s0und

Copy link
Copy Markdown
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the contribution and the unit test!

@macjohnny macjohnny merged commit d29196a into OpenAPITools:master Dec 6, 2024
@ASterdyniak ASterdyniak deleted the fix_issue19039 branch December 6, 2024 10:02
@wing328 wing328 added this to the 7.11.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [typescript-fetch] ModelNamePrefix is added twice to import statements thereby breaking the build

3 participants