Skip to content

Upgrade jmustache to 1.16#19575

Closed
takanuva15 wants to merge 1 commit intoOpenAPITools:masterfrom
takanuva15:master
Closed

Upgrade jmustache to 1.16#19575
takanuva15 wants to merge 1 commit intoOpenAPITools:masterfrom
takanuva15:master

Conversation

@takanuva15
Copy link
Copy Markdown

@takanuva15 takanuva15 commented Sep 13, 2024

Upgrade jmustache to 1.16 to add support for blocks and parents, thus reducing the amount of code needed in templates.

A PR was already raised for this previously at #18314, but it was closed by the owner due to other commitments.

EDIT: Dang it looks like the spacing got weird in a bunch of files. I'm not sure if that's a problem in jmustache or just some weird formatting thing with new templates

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@sellisd
Copy link
Copy Markdown

sellisd commented Jan 30, 2025

⚠️ upgrading to jmustache 1.16 breaks python code generation (among other things) #20375

@bachorp bachorp mentioned this pull request May 29, 2025
5 tasks
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jul 8, 2025

updated in the master so closing this one

still thank you for your contribution

@wing328 wing328 closed this Jul 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants