Fix x-www-form-urlencoded date-time string parameters#18898
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Jul 2, 2024
Merged
Fix x-www-form-urlencoded date-time string parameters#18898macjohnny merged 1 commit intoOpenAPITools:masterfrom
macjohnny merged 1 commit intoOpenAPITools:masterfrom
Conversation
As mentioned in OpenAPITools#13841, date-time parameters in request bodies are not ISO formatted, which breaks with certain webservers. This commit invokes `toISOString()` for date-time body parameters like it is done for queryParameters. Fixes OpenAPITools#13841.
Contributor
Author
|
How many committee members should one tag? Bothering all typescript committee members sounds like overkill, so let's start with 3 |
Member
|
thanks for the PR. cc |
Contributor
Author
|
Anything else that would need doing on my end? |
macjohnny
approved these changes
Jul 2, 2024
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #13841, date-time parameters in request bodies are not ISO formatted, which breaks with certain webservers. This commit invokes
toISOString()for date-time body parameters like it is done for queryParameters.Fixes #13841.
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.6.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)