Skip to content

Kotlin-Spring request mapping mode#18896

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
pstorch:kotlin_spring_request_mapping_mode
Jun 17, 2024
Merged

Kotlin-Spring request mapping mode#18896
wing328 merged 1 commit intoOpenAPITools:masterfrom
pstorch:kotlin_spring_request_mapping_mode

Conversation

@pstorch
Copy link
Copy Markdown
Contributor

@pstorch pstorch commented Jun 10, 2024

RequestMappingMode: Explicit configuration to control the location of the generated class level RequestMapping annotation-

Based on #13838 but for the kotlin-spring generator.

Fixes #18884

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m, @stefankoppier

… the generated class level RequestMapping annotation

Based on OpenAPITools#13838 but for kotlin-spring.

Fixes OpenAPITools#18884
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 17, 2024

lgtm. let's give it a try

thanks for the PR

@wing328 wing328 merged commit c806ea5 into OpenAPITools:master Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] [kotlin-spring] Spring request mapping mode

2 participants