[typescript-fetch] Support fileNaming option (#18283)#18284
Merged
macjohnny merged 3 commits intoOpenAPITools:masterfrom May 3, 2024
Merged
[typescript-fetch] Support fileNaming option (#18283)#18284macjohnny merged 3 commits intoOpenAPITools:masterfrom
macjohnny merged 3 commits intoOpenAPITools:masterfrom
Conversation
c8d3e55 to
d1996a3
Compare
macjohnny
reviewed
Apr 22, 2024
| */ | ||
| private String convertUsingFileNamingConvention(String originalName) { | ||
| String name = originalName; | ||
| if ("kebab-case".equals(fileNaming)) { |
Member
There was a problem hiding this comment.
Please introduce constants and use them in all changed lines
macjohnny
reviewed
Apr 22, 2024
Member
macjohnny
left a comment
There was a problem hiding this comment.
Looks good overall,
Thanks for your contribution!
Please also resolve the merge conflict
e0601af to
5a2457a
Compare
Contributor
Author
|
Thanks for the code review ! Constants had been introduced and conflict resolved. |
macjohnny
approved these changes
May 3, 2024
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add new option "fileNaming" for the typescript-fetch generator with following eligible values :
That option already exists in typescript-angular and typescript-nestjs generators.
fixes: #18283
Original PR for typescript-angular generator: #727
To validate
You can save the following specs in a file called test-spec.yaml
Then run following commands
File names must have the wanted format for each case and those file names must be used in imports.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)