Skip to content

Add package to bean name in converter.mustache for EnumConverterConfiguration.java#17738

Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom
Tomschi:issue-17737-fix-spring-name-collision
Apr 1, 2025
Merged

Add package to bean name in converter.mustache for EnumConverterConfiguration.java#17738
wing328 merged 2 commits intoOpenAPITools:masterfrom
Tomschi:issue-17737-fix-spring-name-collision

Conversation

@Tomschi
Copy link
Copy Markdown
Contributor

@Tomschi Tomschi commented Jan 29, 2024

Add package to bean name in converter.mustache for EnumConverterConfiguration.java to resolve issue #17737

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 5, 2024

can you please follow step 3 to update the samples?

@wing328
Copy link
Copy Markdown
Member

wing328 commented Feb 7, 2024

cc
@cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

@MelleD
Copy link
Copy Markdown
Contributor

MelleD commented Feb 12, 2024

A test that shows the problem would be great

@MelleD
Copy link
Copy Markdown
Contributor

MelleD commented Feb 12, 2024

Here we have a similar issue with the Configuration names:
#17847

Also possible is to remove the @configuration Annotation and we use directly the @import from spring and then everyone can decide where and when the Config will be loaded.

@Tomschi
Copy link
Copy Markdown
Contributor Author

Tomschi commented Feb 23, 2024

A test that shows the problem would be great

I don't think, that there is any useful test. It is the same like the @bean definition.

@Tomschi
Copy link
Copy Markdown
Contributor Author

Tomschi commented Jul 2, 2024

@Tomschi
Copy link
Copy Markdown
Contributor Author

Tomschi commented Feb 27, 2025

How do we proceed from here? Is the example enough to become a approvement?

Copy link
Copy Markdown
Contributor

@martin-mfg martin-mfg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Tomschi, thanks for the PR. Yes, I think the linked example is a good way to show the problem.
LGTM

@jorgerod
Copy link
Copy Markdown
Contributor

jorgerod commented Mar 31, 2025

Hi @martin-mfg

I see that it is already to be merged, why don't you merge it?

@martin-mfg
Copy link
Copy Markdown
Contributor

Hi @martin-mfg

I see that it is already to be merged, why don't you merge it?

Because I'm not a maintainer of this project and therefore don't have permissions to merge. Please check with @wing328 about merging this PR. :)

@wing328 wing328 merged commit 4f3726e into OpenAPITools:master Apr 1, 2025
@wing328 wing328 changed the title #11737 Add package to bean name in converter.mustache for EnumConverterConfiguration.java Add package to bean name in converter.mustache for EnumConverterConfiguration.java Apr 1, 2025
@wing328 wing328 added this to the 7.13.0 milestone Apr 1, 2025
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 1, 2025

thanks for the PR, which has been merged

sorry for the delay in reviewing as there are too many PRs pending review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants