Add package to bean name in converter.mustache for EnumConverterConfiguration.java#17738
Conversation
|
can you please follow step 3 to update the samples? |
|
cc |
|
A test that shows the problem would be great |
|
Here we have a similar issue with the Configuration names: Also possible is to remove the @configuration Annotation and we use directly the @import from spring and then everyone can decide where and when the Config will be loaded. |
I don't think, that there is any useful test. It is the same like the @bean definition. |
|
Here is an example to reproduce the issue: https://github.com/Tomschi/openapi-generator-issues |
|
How do we proceed from here? Is the example enough to become a approvement? |
martin-mfg
left a comment
There was a problem hiding this comment.
Hi @Tomschi, thanks for the PR. Yes, I think the linked example is a good way to show the problem.
LGTM
|
Hi @martin-mfg I see that it is already to be merged, why don't you merge it? |
Because I'm not a maintainer of this project and therefore don't have permissions to merge. Please check with @wing328 about merging this PR. :) |
|
thanks for the PR, which has been merged sorry for the delay in reviewing as there are too many PRs pending review. |
Add package to bean name in converter.mustache for EnumConverterConfiguration.java to resolve issue #17737
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)