Skip to content

chore(deps,rust): requires reqwest 0.11 in blocking generated code#16927

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
KisaragiEffective:fix/deps/reqwest-0.11
Oct 28, 2023
Merged

chore(deps,rust): requires reqwest 0.11 in blocking generated code#16927
wing328 merged 3 commits intoOpenAPITools:masterfrom
KisaragiEffective:fix/deps/reqwest-0.11

Conversation

@KisaragiEffective
Copy link
Copy Markdown
Contributor

Requires reqwest 0.11 even if code was generated in blocking mode.

close #15549

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 28, 2023

thanks for the PR.

tested locally and the result is good.

(there's an issue with samples/client/petstore/rust/reqwest/petstore/tests/type_testing.rs but not related to this change)

@wing328 wing328 merged commit d671b83 into OpenAPITools:master Oct 28, 2023
@KisaragiEffective KisaragiEffective deleted the fix/deps/reqwest-0.11 branch October 28, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[REQ] Updating Rust reqwest from 0.9 to 0.11 when using async

2 participants