Skip to content

[PHP-SYMFONY] Support BackedEnum for enum ref (16846)#16847

Merged
wing328 merged 8 commits intoOpenAPITools:masterfrom
loicconan:php_symfony_backed_enum
Nov 7, 2023
Merged

[PHP-SYMFONY] Support BackedEnum for enum ref (16846)#16847
wing328 merged 8 commits intoOpenAPITools:masterfrom
loicconan:php_symfony_backed_enum

Conversation

@loicconan
Copy link
Copy Markdown
Contributor

@loicconan loicconan commented Oct 17, 2023 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@loicconan loicconan mentioned this pull request Oct 17, 2023
Closed
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 18, 2023

cc @jebentier (2017/07), @dkarlovi (2017/07), @mandrean (2017/08), @jfastnacht (2017/09), @ybelenko (2018/07), @renepardon (2018/12)

@loicconan
Copy link
Copy Markdown
Contributor Author

loicconan commented Oct 19, 2023

Phpunit didn't pass. I fixed it.

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 31, 2023

@loicconan can you please take another look when you've time?

There was 1 error:

1) OpenAPI\Server\Model\EnumStringModelTest::testTestClassExists
Error: Typed property OpenAPI\Server\Model\EnumStringModelTest::$object must not be accessed before initialization

ref: https://github.com/OpenAPITools/openapi-generator/actions/runs/6575244536/job/18214218454?pr=16847

@loicconan
Copy link
Copy Markdown
Contributor Author

loicconan commented Nov 7, 2023

@loicconan can you please take another look when you've time?

There was 1 error:

1) OpenAPI\Server\Model\EnumStringModelTest::testTestClassExists
Error: Typed property OpenAPI\Server\Model\EnumStringModelTest::$object must not be accessed before initialization

ref: https://github.com/OpenAPITools/openapi-generator/actions/runs/6575244536/job/18214218454?pr=16847

Hello @wing328 I fixed it.

@wing328 wing328 merged commit d945499 into OpenAPITools:master Nov 7, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Nov 7, 2023

thanks for the fix, which has been merged.

@wing328 wing328 added this to the 7.1.0 milestone Nov 11, 2023
@loicconan loicconan deleted the php_symfony_backed_enum branch June 24, 2024 13:13
@JerrySLau JerrySLau mentioned this pull request Apr 14, 2026
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement: Feature Feature: Enum Server: PHP

Projects

None yet

Milestone

7.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@loicconan @wing328