Skip to content

[PHP-Symfony] fix #15950: Add float to deserialize#16835

Merged
wing328 merged 3 commits intoOpenAPITools:masterfrom
DaxServer:fix-issue-15950
Oct 16, 2023
Merged

[PHP-Symfony] fix #15950: Add float to deserialize#16835
wing328 merged 3 commits intoOpenAPITools:masterfrom
DaxServer:fix-issue-15950

Conversation

@DaxServer
Copy link
Copy Markdown
Contributor

@DaxServer DaxServer commented Oct 16, 2023

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Fixes #15950
Pinging PHP technical committee members - @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon

@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 16, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@DaxServer
Copy link
Copy Markdown
Contributor Author

DaxServer commented Oct 16, 2023 via email

@wing328 wing328 merged commit 8bb4733 into OpenAPITools:master Oct 16, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Oct 16, 2023

merged. thanks for the PR.

@wing328 wing328 added this to the 7.1.0 milestone Oct 16, 2023
@DaxServer DaxServer deleted the fix-issue-15950 branch October 16, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][SYMFONY-PHP] Type float is unsupported

2 participants