[BUG][GO] Add support for all +json and +xml suffixed media types#16816
[BUG][GO] Add support for all +json and +xml suffixed media types#16816wing328 merged 3 commits intoOpenAPITools:masterfrom
Conversation
|
thanks for the PR. what about creating a new file named api_cliet_test.go in https://github.com/OpenAPITools/openapi-generator/tree/master/samples/openapi3/client/petstore/go and add some tests for xmlCheck, jsonCheck? |
|
Thanks for pointing me in the right direction. The members had to be exported in order to test them outside of the package but that shouldn't be a problem. Does https://github.com/OpenAPITools/openapi-generator/tree/master/samples/client/petstore/go need the tests as well? |
No. Eventually we will consolidate the Go petstore tests to use only OpenAPI v3 spec. Have a nice weekend |
Fixes #16811
I don't see tests for the generated client in the repo so I threw together these tests just to sanity-check. They passed ✅.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)