python: run the Python samples tests with GitHub Actions#16643
python: run the Python samples tests with GitHub Actions#16643wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
| - "3.8" | ||
| - "3.9" | ||
| - "3.10" | ||
| #- "3.11" |
There was a problem hiding this comment.
may I know why 3.11 is skipped?
There was a problem hiding this comment.
There are some issues in the petstore tests, I will propose a fix so that we can enable 3.11 👍
| import urllib3 | ||
|
|
||
| HOST = 'http://petstore.swagger.io/v2' | ||
| HOST = 'http://localhost/v2' |
There was a problem hiding this comment.
i think we will need to do the same for the python aiohttp samples as well. maybe better to simply update the host table. i will do it with another PR.
There was a problem hiding this comment.
Actually, the aiohttp samples already use the correct HOST value: https://github.com/multani/openapi-generator/blob/29033bf62ac202b00ca70dc7bdcba5c58b6bd7f8/samples/openapi3/client/petstore/python-aiohttp/tests/test_pet_api.py#L27
|
LGTM. We can go with what you've for the time being. |
This runs more Python tests through GitHub Actions, with multiple code base and multiple Python versions.
I used this a lot to test my change in #16624, which is difficult to fully assess if nothing exercises the generated Python code.
@krjakbrjak as Python tech-comittee
@wing328 as the previous editor on the
echo_clientsample + GitHub Action workflowSee: #16643
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)