fix(#9682): API class has multiple imports of 'okhttp3.ResponseBody'#16638
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Sep 22, 2023
Merged
fix(#9682): API class has multiple imports of 'okhttp3.ResponseBody'#16638wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
tested with https://gist.githubusercontent.com/p33t/d518225d4b117ff8b94fff4b0fbe30b2/raw/a1c30815ead05c9b9311f5dec07c08fdd17127ee/petstore-minimal2.json and able to repeat the issue, and also confirm the fix. thanks for the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes duplicate imports of okhttp3.ResponseBody.
Instead of adding the import for every operation, this sets a "global" variable isResponseFile as already expected by api.mustache.
Adding the import for every operation (that has isResponseFile set to true) was introduced in #9239 and lead to non-compiling generated Apis as multiple imports are not allowed.
This fixes #9682.
@jimschubert can you review this?
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)