fix(golang): make sure xml.Encoder is closed#16141
fix(golang): make sure xml.Encoder is closed#16141wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
dfe3d5e to
81bd83c
Compare
|
The |
|
thanks for the PR. CI failed with errors: https://app.circleci.com/pipelines/github/OpenAPITools/openapi-generator/24812/workflows/5e1fba49-7f46-4b8e-83f7-723066699134/jobs/73874 please take a look when you've time. |
|
That CI job runs on How long does OpenAPI support older versions of Go? |
|
My opinion is that it should be supported until the version is EOL |
81bd83c to
2ce6640
Compare
|
I've pushed a fix for older versions of Go. When a newer version of Go is used to compile code after generation it will call |
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)/cc @lwj5