Skip to content

[Kotlin-Spring] fix use of isBasic from #15048#15759

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
tiffmaelite:fix/isBasic_kotlin_2
Jun 6, 2023
Merged

[Kotlin-Spring] fix use of isBasic from #15048#15759
wing328 merged 1 commit intoOpenAPITools:masterfrom
tiffmaelite:fix/isBasic_kotlin_2

Conversation

@tiffmaelite
Copy link
Copy Markdown
Contributor

@tiffmaelite tiffmaelite commented Jun 5, 2023

Follow-up of the other "fix use of isBasic" PR series, but for code from new kotlin-spring generator developed in parallel

isBasic is also true for HTTP bearer auth method and HTTP signature method, not only HTTP basic auth method; it should not be used when we want to apply code changes in the context of HTTP basic auth only!

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

new generator creator: @gr4cza
technical committee: @jimschubert (2017/09) ❤️, @dr4ke616 (2018/08) @karismann (2019/03) @Zomzog (2019/04) @andrewemery (2019/10) @4brunu (2019/11) @yutaka0m (2020/03) @stefankoppier (2022/06)

@stefankoppier
Copy link
Copy Markdown
Contributor

Thanks :) LGTM @wing328

@wing328 wing328 added this to the 7.0.0 milestone Jun 6, 2023
@wing328 wing328 merged commit 366e71a into OpenAPITools:master Jun 6, 2023
@tiffmaelite tiffmaelite deleted the fix/isBasic_kotlin_2 branch June 6, 2023 06:19
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants