Skip to content

[Python] Added BadRequestException as a subclass in python exceptions#15722

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
gyoganathan:python-exception-bad-request
Jun 10, 2023
Merged

[Python] Added BadRequestException as a subclass in python exceptions#15722
wing328 merged 1 commit intoOpenAPITools:masterfrom
gyoganathan:python-exception-bad-request

Conversation

@gyoganathan
Copy link
Copy Markdown
Contributor

@gyoganathan gyoganathan commented Jun 1, 2023

Added BadRequestException as a subclass in python exceptions in order to validate the exceptions precisely

@spacether @krjakbrjak

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@gyoganathan gyoganathan force-pushed the python-exception-bad-request branch from 7def309 to a1cd045 Compare June 1, 2023 21:37
@gyoganathan gyoganathan changed the title Added BadRequestException as a subclass in python exceptions [Python] Added BadRequestException as a subclass in python exceptions Jun 2, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Jun 3, 2023

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added Enhancement: General python Pull requests that update Python code labels Jun 10, 2023
@wing328 wing328 merged commit fc474ea into OpenAPITools:master Jun 10, 2023
@wing328 wing328 added this to the 7.0.0 milestone Jun 10, 2023
amakrushin pushed a commit to amakrushin/openapi-generator that referenced this pull request Jun 12, 2023
fmoraespadtec pushed a commit to padteclab/openapi-generator that referenced this pull request Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement: General python Pull requests that update Python code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants