Allow configuration cache compatibility#15693
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Jun 9, 2023
Merged
Conversation
Use FileSystemOperations to delete output folder if Gradle Version >= 6
jprinet
force-pushed
the
fix/configuration-cache-compatibility
branch
from
ed091b5 to
d446678
Compare
Contributor
Author
|
Just realized that Gradle 5.6.1 used in the newly introduced |
Contributor
Author
|
I found a way but having TestNg to provide a DisabledForJreRange would have greatly helped |
jprinet
force-pushed
the
fix/configuration-cache-compatibility
branch
from
5f80c36 to
f440008
Compare
erichaagdev
approved these changes
Jun 5, 2023
Member
|
cc @OpenAPITools/generator-core-team |
amakrushin
pushed a commit
to amakrushin/openapi-generator
that referenced
this pull request
Jun 12, 2023
* Allow configuration cache compatibility Use FileSystemOperations to delete output folder if Gradle Version >= 6 * Skip Gradle legacy test if JDK is not compatible
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
* Allow configuration cache compatibility Use FileSystemOperations to delete output folder if Gradle Version >= 6 * Skip Gradle legacy test if JDK is not compatible
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FileSystemOperationsto delete output folder if Gradle Version >= 6GenerateTaskConfigurationCacheTesttest classFixes #15692
Please note that the FileSystemOperations has been introduced with Gradle 6.0 and this is the reason why we need to condition its usage.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)