[dart-dio] Use sourceFolder property instead of src#15620
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Jun 13, 2023
Merged
[dart-dio] Use sourceFolder property instead of src#15620wing328 merged 1 commit intoOpenAPITools:masterfrom
wing328 merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
cc @jaumard (2018/09) @josh-burton (2019/12) @amondnet (2019/12) @sbu-WBT (2020/12) @kuhnroyal (2020/12) @agilob (2020/12) @ahmednfwela (2021/08) |
ahmednfwela
suggested changes
Jun 10, 2023
kuhnroyal
reviewed
Jun 11, 2023
Contributor
kuhnroyal
left a comment
There was a problem hiding this comment.
LGTM, just need to remove that empty line.
64a2c27 to
fa5cdf5
Compare
ahmednfwela
approved these changes
Jun 12, 2023
Contributor
ahmednfwela
left a comment
There was a problem hiding this comment.
it's fine , all of these files will get edited in my PR anyway after merging both dart generators
fa5cdf5 to
7d02fcd
Compare
Contributor
Author
|
Regenerated to fix all the extra new-lines. |
fmoraespadtec
pushed a commit
to padteclab/openapi-generator
that referenced
this pull request
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dart-dio generator had a couple of hard-coded
/src/paths which meant the resulting code didn't work if you used a the customsourceFolderproperty as it was importing from a directory that didn't exist.This change results in no differences in the generated code since the default source directory is already
src(although a new line got added when I ran the scripts in the instructions so I've committed that) so should be non-breaking.PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)