Skip to content

[go-server] fix string comparison#15589

Merged
wing328 merged 1 commit intomasterfrom
fix-go
May 24, 2023
Merged

[go-server] fix string comparison#15589
wing328 merged 1 commit intomasterfrom
fix-go

Conversation

@wing328
Copy link
Copy Markdown
Member

@wing328 wing328 commented May 21, 2023

Fix go server string comparison using StringUtils.isNotEmpty

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @jirikuncar (2021/01) @ph4r5h4d (2021/04) @lwj5 (2023/04)

@wing328 wing328 added this to the 7.0.0 milestone May 21, 2023
@wing328 wing328 changed the title Fix go server string comparison [go-server] fix string comparison May 21, 2023
@lwj5
Copy link
Copy Markdown
Contributor

lwj5 commented May 24, 2023

nice clean-up!

@wing328 wing328 merged commit 15604b3 into master May 24, 2023
@wing328 wing328 deleted the fix-go branch May 24, 2023 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants