[elixir] Fixes BadMapError for header parameters#1537
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Nov 27, 2018
Merged
[elixir] Fixes BadMapError for header parameters#1537wing328 merged 2 commits intoOpenAPITools:masterfrom
BadMapError for header parameters#1537wing328 merged 2 commits intoOpenAPITools:masterfrom
Conversation
4 tasks
Member
|
@mrmstn thanks for the PR, which has been included in the v3.3.4 release: https://twitter.com/oas_generator/status/1068772409795207168 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Adds :headers as expected param mapping * Gen Petstore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
There's a issue with the current
request_builder.exsince Tesla expects header parameters to be a map as they are unique. The request_builder.ex has in the current version no "special treatment" for the header parameters which will result inBadMapErrorsince it tires to merge the map from tesla with the key-value list from the request_builder.The full error message looks something like the following
I made a small yml to reproduce the issue:
then I ran the follwing command in my iex (
mix deps.getandiex -S mix)SwaggerPetstore.Api.Invoice.get_invoice(SwaggerPetstore.Connection.new(), "123")Could you give me the honor and check my conclusion and code @wing328 ?