[elixir] Typespec: Fixes issue with formated primitivs as parameters#1534
Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom Nov 27, 2018
Merged
Conversation
4 tasks
Member
|
There may be another way to fix this. Let me check further. |
Member
|
I did a bit more debugging and it's because |
Member
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.4.x,4.0.x. Default:master.Description of the PR
I had a issue that formatted strings as parameter won't be treated as primitivs ( this might be a issue in the global scope? ) which will result in Typespec like
MyApi.Model.String.t.t. With this PR, the resulting typespec will beString.t(or what ever datetype mapping has been done before).To proof my point, the yml for the sample need to have something like the following lines. I'm not quite sure how to do that - could you help me out on this one? @wing328
Here's a sample of the difference:
old:
new: