Using @objcMembers to expose all props and funcs to ObjC#15188
Merged
4brunu merged 1 commit intoOpenAPITools:masterfrom Apr 14, 2023
Merged
Using @objcMembers to expose all props and funcs to ObjC#151884brunu merged 1 commit intoOpenAPITools:masterfrom
4brunu merged 1 commit intoOpenAPITools:masterfrom
Conversation
Member
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
… code when objcCompatible is requested.
4d944f5 to
fff1eef
Compare
Contributor
Author
|
@wing328 Ok, I hope that fixed it. Incorrectly juggled work email with GitHub email. |
4brunu
approved these changes
Apr 14, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the
objcCompatibleoption for swift5, this will add@objcMembersinstead of@objcat the generated class level for Models and APIs so that all properties and functions will be visible by Objective-C. I had suggested this in issue 13175 as an enhancement.I've re-generated the samples, which now reflect this change, and there are no changes to docs.
Attn: @jgavris @ehyche @Edubits @jaz-ah @4brunu
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)