Skip to content

[Elm] Fix List of type missing required import(s)#15171

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
Qluxzz:elm-client-nested-types-has-correct-includes
Apr 13, 2023
Merged

[Elm] Fix List of type missing required import(s)#15171
wing328 merged 1 commit intoOpenAPITools:masterfrom
Qluxzz:elm-client-nested-types-has-correct-includes

Conversation

@Qluxzz
Copy link
Copy Markdown
Contributor

@Qluxzz Qluxzz commented Apr 9, 2023

Currently, if you have the type List Uuid, the needed import from Uuid won't be included. This is the same for List Posix which doesn't include the needed import from Api.Time.

Fixed so function recursively checks if the list's item type is UUID or Posix, and then sets flags (includeUuid/includeTime) accordingly.

Added test cases to validate changes.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script :
    ./bin/utils/ensure-up-to-date.sh
    
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
    @eriktim

@Qluxzz Qluxzz changed the title [Elm] Fix List of type is missing required import(s) [Elm] Fix List of type missing required import(s) Apr 9, 2023
@wing328 wing328 added this to the 6.6.0 milestone Apr 10, 2023
@wing328
Copy link
Copy Markdown
Member

wing328 commented Apr 13, 2023

Thanks for the PR and the tests. Let's give it a try.

@wing328 wing328 merged commit 241d649 into OpenAPITools:master Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants